Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Helper Texts in Empty Tabs #281

Closed
AmanNegi opened this issue Oct 28, 2022 · 7 comments · May be fixed by #282
Closed

Add Helper Texts in Empty Tabs #281

AmanNegi opened this issue Oct 28, 2022 · 7 comments · May be fixed by #282
Assignees
@AmanNegi

Comments

@AmanNegi
Copy link
Contributor

Steps to Reproduce

  1. Create a new account in WGER and login into the app.
  2. After you log in you will be navigated to the home page with 5 tabs.
  3. Switching to 2,3 or 5th Tab, shows an empty screen. The tabs are Workout, Nutrition, and Gallery.

Expected results:
It would be great to see a message which says no items available or some helper text at least.

Actual results:
Currently, we see a blank screen with no idea what is happening.
@AmanNegi
Copy link
Contributor Author

@rolandgeider Let me know if this issue is valid and if it is please assign it to me I would be happy to resolve it. 😊🙌

@rolandgeider
Copy link
Member

yes, informing the user isn't a bad idea. I would use a generic text instead of something specific to the tab as to keep the amount of text that needs to be translated to a minimum (so something like "no items" instead of "no workout routines")

@AmanNegi
Copy link
Contributor Author

Okay a common text would be perfect so that it can be reused. 🤗👍

AmanNegi added a commit to AmanNegi/flutter that referenced this issue Oct 28, 2022
@AmanNegi
Add Helper text to Empty Tabs wger-project#281
0da8eed
@AmanNegi AmanNegi mentioned this issue Oct 28, 2022
Open
@AmanNegi
Copy link
Contributor Author

@rolandgeider Any updates on this?

@rolandgeider rolandgeider linked a pull request Oct 31, 2022 that will close this issue
Add Helper text to Empty Tabs #281 #282
Open
@AmanNegi
Copy link
Contributor Author

@rolandgeider could you please merge this issue by today?

@rolandgeider
Copy link
Member

I've just approved it so it counts as well 👍🏻

@AmanNegi
Copy link
Contributor Author

Thanks a lot !! 🤗💓✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmanNegi AmanNegi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Helper text to Empty Tabs #281 AmanNegi/flutter
2 participants
@rolandgeider @AmanNegi