<other-identifier> question which data is being displayed

[siwhitehouse]

Relates to previous issue #53 where I suspect I mislead you.

As per:

http://iatistandard.org/activities-standard/other-activity-identifiers/

We ought to be pulling through the element's content rather than the owner-ref attribute.

eg. http://aidview-dev.herokuapp.com/activity/AU-5-INJ559-FJ

displays AU-5 which is a reference to the activity's owner.

whereas: http://aidview-dev.herokuapp.com/activity/GB-CHC-285776-ZIM361 is blank when it should show ZIM361 as per this response from the API

http://data.aidinfolabs.org/xquery/woapi.xq?ID=GB-CHC-285776-ZIM361&search=&start-date=&end-date=&start=1&pagesize=20&result=full&callback=&corpus=main&test=yes

I hope this is a superficial fix.

[benfoxall]

I've put in a fix so that the <other-identifier> content is displayed, though in the example above - the id isn't shown, because other-identifier is empty in the api request.

Does this make sense? Have I misunderstood the issue?

[siwhitehouse]

Hi Ben

I'm really sorry, I messed up the issue - I've edited it now so it ought to make sense.

The first example ought to be blank because, as you say, other-identifier is empty in the api request. However, when I look in AidView - http://aidview-dev.herokuapp.com/activity/AU-5-INJ559-FJ - I see "AusAID" under "Other activity identifiers".

http://aidview-dev.herokuapp.com/activity/GB-CHC-285776-ZIM361

Is correctly showing ZIM361 under "Other activity identifiers"

So, if we fix the code that is pulling AusAID in the first example we ought to be good.

[benfoxall]

Okay, so now if you have no content in the other-identifier element:

<other-identifier owner-ref="AU-5" owner-name="AusAID"/>

(from AU-5-INJ559-FJ ) … the other identifier will be skipped in the UI.

[siwhitehouse]

Thanks Ben, I'm happy that this is ok to be closed.