Replies: 2 comments 2 replies
-
Hi Hefin, You're almost there. The issue is that the
Note that plotting quadrant gates only works for the I do realize it is tedious to construct Quadrant gates. The current API is a mapping from the GatingML specification and I'd love to find a simpler way to create them. Let me know if this helps, |
Beta Was this translation helpful? Give feedback.
-
Hi Hefin, Unfortunately, exporting Quadrant gates to a FlowJo workspace isn't supported yet. Attempting to do so was supposed to throw a The reason why it isn't implemented actually relates directly to the discussion of why the quadrant gates are so tedious to create. The GatingML specification overloads the definition of a quadrant gate beyond the true mathematical definition of 2 dividers creating 4 quadrants. It allows an arbitrary number of dividers along with merging of the resulting "quadrants". If you'd like to read it (great for insomnia!), the QuadrantGate definition is in section 5.4 (GatingML PDF). Here's an example they use that illustrates this: The GatingML spec overloads things in a few other places as well. IMO, it is overly ambitious, trying to cover as many use cases as possible, but sacrificing simplicity. One could achieve the same result using range gates with Boolean gates. In any case, I believe this is why FlowJo (and other packages) do not implement GatingML compliant quadrant gates, and is also the reason FlowKit doesn't export the current QuadrantGate to FlowJo workspaces. So, how to solve this? FlowKit does have "WSP" prefixed gates (actually just WSPEllipsoidGate for now) for FlowJo compatible versions of gates. I could create a simple WSPQuadrantGate that could hopefully match the simplicity of the flowWorkspace API. Curious your thoughts on whether that would be a good idea or just make things more confusing. I should note the upcoming 1.2 release is focused on simplifying the API in situations like this. Another example I'd like to address is the admittedly odd way the rectangle / range boundaries are specified in the dimension instances instead of in the gate class directly (another artifact of mirroring GatingML). I'm not sure when it will be released but I would consider trying to work in a quadrant gate fix. And I welcome any other feedback you might have regarding the API. Kind regards, |
Beta Was this translation helpful? Give feedback.
-
Hi all, thanks for making such an excellent package. My question is: what's the correct way to visualize quadrant gates? I tried applying the same method I use for rectangle, polygon, and ellipsoid gates, but I can't get it to work. Here is an MWE (assuming
test_data_diamond_01.fcs
is indata
in the working directory):I came across #41 but couldn't find any documentation of the best way to do it. Ideally I would like to either plot all quadrants together in the same plot.
Best wishes
Hefin
EDIT: I also find I get a
QuadrantReferenceError
when runningsession.export_wsp(...)
, which I think may be related. So now I'm wondering if I've constructed the gate incorrectly.Beta Was this translation helpful? Give feedback.
All reactions