Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to tab out of the element #90

Open
bureson opened this issue Oct 9, 2017 · 5 comments
Open

Impossible to tab out of the element #90

bureson opened this issue Oct 9, 2017 · 5 comments

Comments

@bureson
Copy link

bureson commented Oct 9, 2017

With the change from the last commit 861918d where you moved ev.preventDefault() up for all keys in 'handleKeyDown' you disabled all native keyboard functionality, for example tabbing between other elements on page. It is a serious flaw for accessibility.
bureson referenced this issue Oct 9, 2017
@whoisandy
feat(slider): support for click and drag, accessibility
177d433 
closes #50, #52
fixes #60, #71, #73, #79

BREAKING CHANGE:

`rangeslider__label-list` renamed to `rangeslider__labels` & `rangeslider__labels-item`
@IanAbildskou
Copy link

bump

@paustint
Copy link

Looks like PR #82 is open to correct the broken changes from commit 861918d

@paustint paustint mentioned this issue Oct 18, 2017
Open
@chrishutchinson
Copy link
Contributor

I have tweeted the maintainer to encourage #82 to be merged, hopefully we’ll see some movement soon

@zhrivodkin
Copy link

As I see, nothing happens here for a month.

@paustint
Copy link

paustint commented Oct 26, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chrishutchinson @zhrivodkin @paustint @bureson @IanAbildskou