Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select2] Update Bootstrap theme? #672

Closed
florianlacreuse opened this issue Aug 23, 2019 · 4 comments
Closed

[Select2] Update Bootstrap theme? #672

florianlacreuse opened this issue Aug 23, 2019 · 4 comments

Comments

@florianlacreuse
Copy link
Contributor

4 years ago, Select2 Bootstrap theme was added to wicketstuff-select2 but it it hasn't been updated since.

I could do a PR if needed but I was wondering if either:

  • We should stick it with Bootstrap 3 and in this case we will use the 0.1.0-beta.10 release from select2/select2-bootstrap-theme. The lastest release was 2 years ago, the project seems rather dead.
  • We should upgrade to Bootstrap 4. In our projects, we use this fork for BS4. This fork was made for this pending PR (select2/select2-bootstrap-theme).

Also, we could update the select2-examples project to use BS3 or BS4 instead of BS2, and may be some examples with the Bootstrap theme?

@solomax
Copy link
Contributor

solomax commented Aug 23, 2019

I do prefer latest versions :)
Unfortunately I have no enough free time to dig into topic :(
Feel free to create PR, so we can discuss it :)

@florianlacreuse
Copy link
Contributor Author

Thanks for the first feedback! PR done: #673.

@florianlacreuse
Copy link
Contributor Author

PR is merged but we still need to figure out what to do with having a select2 bootstrap theme inside wicketstuff-select2. Drop it? Only support BS4? Support BS4 and BS3, if so, how?

See my message in the PR thread.

@florianlacreuse
Copy link
Contributor Author

PR has been merged and it seems it's OK to upgrade to BS4 in master branch. I close this issue.

@solomax Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants