Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT: DropdownButton Component #161

Open
wijohnst opened this issue Nov 7, 2022 · 1 comment
Open

ENHANCEMENT: DropdownButton Component #161

wijohnst opened this issue Nov 7, 2022 · 1 comment

Comments

@wijohnst
Copy link
Owner

wijohnst commented Nov 7, 2022

Dropdown specific wrapper component around aButton component

Image
Screen shot, Button component with CaretIcon

This Button is the default state and control for the Dropdown component. The final Dropdown component will have 2 children, DropdownButton and DropdownMenu:

<Dropdown> // <- We will build this later
  <DropdownButton /> // <- This is what we are building
  <DropdownMenu /> // <- Will build this later
</Dropdown>

This pattern is modeled after the React Bootstrap Dropdown component

@wijohnst
Copy link
Owner Author

wijohnst commented Nov 7, 2022

Separation of Concerns

Separation of Concern is the big thing that I'm starting to think about as we build the DropdownButton component. DropdownButton and DropdownMenu are both Dumb Components:

Image
"Dumb" Component Overview"

Basically we need to make sure that most of the functionality for both of these components is passed down as props from either Dropdown (top-level component) or from some other parent context. Let's make sure we talk about his in detail.

@wijohnst wijohnst mentioned this issue Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant