-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TP_UI - Issues 137 & 148 - Adds image upload component to Profile Page #153
Conversation
Closes #137 |
Closes #87 |
Closes #153 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a test comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
src/stories/pages/ProfilePage/ProfilePageRender/ProfilePageRender.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self Review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and one small comment:
- How were you viewing the edit profile page for the screen capture provided? I couldn't find a way to view it like that other than altering the conditional in
ProfilePage.tsx
. Storybook seems to provide the aesthetics but not the functionality. - Nit: the 'cancel'
CTALink
below the submit button might look better with some space between it and theEditProfileForm
component. Feel free to disregard if that is the preferred look you're going for.
Great question. I can view the edit profile page because I am also running the backend locally. This is actually one of the big problems that we still need to address (with Docker containers?). Basically, how can we securely share the backend in an open source project? The BE code requires a local |
Ahh I see. Definitely better to keep that local or figure out a secure way to handle it. I've never used Docker but I know its very popular these days. Worth looking into. |
FP_UI - #137 - Add Upload Component to Profile Page
FP_UI - #138 - Adds
PhotoUpload
story toProfileHeader
componentTL/DR
This PR adds an
Upload
input to the Profile Page when a user clicks the edit profile picture icon. This input will only accept image files. Currently this upload will only print a confirmation message to the console when an image is selected. Uploading the image to AWS S3 will be implemented at a later date when it is unblocked on the backend.This PR also adds additional controls to the Profile Page. These include:
Screen capture, additional cancel action clicks
Overview of Changes
ProfilePage.tsx
data
exists before renderingonCancelEdit
andonCancelPhotoUploadClick
event handlersUpload.tsx
testId
prop for custom test idsProfilePageRender.tsx
isPhotoUpload
propisPhotoUpload
is trueonCancelEditClick
andonCancelPhotoUploadClick
propsProfilePageRender.stories.tsx
UploadPhoto
storyProfilePageRender.test.tsx
CTALink.tsx
hideUnderline
propCTALink.style.ts
CTALink.stories.tsx
HideUnderline
storyProfileHeader.tsx
photoUpload
propicon
based onisPhotoUpload
propProfileHeader.stories.tsx
PhotoUpload
storyEdit.tsx
Edit.style.tsx