Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default (blocking) AddressResolverProvider #42

Closed
gaol opened this issue Nov 28, 2024 · 0 comments · Fixed by #44
Closed

Use the default (blocking) AddressResolverProvider #42

gaol opened this issue Nov 28, 2024 · 0 comments · Fixed by #44
Assignees
Labels
WildFly Demand from WildFly community
Milestone

Comments

@gaol
Copy link
Collaborator

gaol commented Nov 28, 2024

The async AddressResolverProvider implementation in Vertx uses unstable API currently[1], so we need to use the default blocking one like what it is done in opentelemetry subsystem[2].

[1] https://github.com/eclipse-vertx/vert.x/blob/d5a16c6801df5dbdb5474fc01c4304686edb1e69/src/main/java/io/vertx/core/spi/resolver/ResolverProvider.java#L36-L37

[2] https://github.com/wildfly/wildfly/blob/6f635a6f14e888a64bd429155afc233a4f6eb1fe/observability/opentelemetry/src/main/java/org/wildfly/extension/opentelemetry/OpenTelemetrySubsystemRegistrar.java#L184-L187

@gaol gaol added the WildFly Demand from WildFly community label Nov 28, 2024
@gaol gaol added this to the 1.0.1.Final milestone Nov 28, 2024
@gaol gaol self-assigned this Nov 28, 2024
@gaol gaol closed this as completed in #44 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WildFly Demand from WildFly community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant