-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-6383] throwing boot errors if super.boot fails #5659
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@bstansberry can you review this please? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you prepare a custom integration Job using your topic branches and link them to this PR?
WildFly requires this PR and the other way around, so an integration Job picking up your topic branches will allow us to test both PRs in conjunction before merging them.
Integration Jobs are available at https://ci.wildfly.org/buildConfiguration/WF_WildFlyCoreIntegrationExperiments
@yersan Ok, I gave it a try, it is job no 1192. |
@yersan The integration job passed successfully, see https://ci.wildfly.org/buildConfiguration/WF_WildFlyCoreIntegrationExperiments/392051 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @istudens , looks good to me, we will merge this one as the last PR for the final release.
Could you rebase and fix the conflicts?
45f0ede
to
29dee92
Compare
29dee92
to
b22fcd1
Compare
done |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Thanks @istudens |
Issue: https://issues.redhat.com/browse/WFCORE-6383
With this fix the
ModelTestControllerService.boot()
always throws newBootOperationFailedException
ifsuper.boot
returnsfalse
.Note that a few test-cases had to be changed according to it.
Regarding "BTW, I think the entire class can and should be package protected, but if there's some outside use I've missed, then never mind.", it is not possible as
BootErrorCollector
is also used outside the package.Note 2: This will need a fix in WildFly code base in two PicketLink Subsystem tests. I will create a separate Jira for it.