Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to enable EnableChildWildcardSearch in pr #1514? #2248

Open
cesaryuan opened this issue Oct 22, 2024 · 2 comments
Open

How to enable EnableChildWildcardSearch in pr #1514? #2248

cesaryuan opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels

Comments

@cesaryuan
Copy link

Brief description of your issue

The commit 30fd9b7 mentioned in #1514 seems to be lost. I can not search any "EnableChildWildcardSearch" text in repo.

This means that the pr #1514 not work any more.

image

Steps to reproduce (optional)

No response

Expected behavior (optional)

No response

Actual behavior (optional)

No response

Environment (optional)

No response

@dmex
Copy link
Member

dmex commented Nov 19, 2024

The commit 30fd9b7 mentioned in #1514 seems to be lost.

No?

4296647

I can not search any "EnableChildWildcardSearch" text in repo. This means that the pr #1514 not work any more.

Those changes were deleted by @jxy-s in this commit: 481211b

@jxy-s
Copy link
Member

jxy-s commented Dec 10, 2024

That functionality was removed since the responsibility of matching was moved into the searchbox logic and with the addition of regular expressions there was not obvious way to support both at that time. I think restoring something similar alongside the new logic shouldn't be that hard. Although the magic values * and | might not be supported as before. I think perhaps an option to just include child processes in the search results for a given matched process might suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants