Remove dependency on pytz #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jenselme Can you update the PR to use https://pypi.org/project/tzdata/? As mentioned in Python's docs, Windows does "not have an IANA database available", and sure enough agate's tests fail on Windows. |
Starting with Python 3.9 a zoneinfo package is available in the standard library for this feature. There is therefore no need for this dependency and a compatibility layer is available at https://pypi.org/project/backports.zoneinfo/ for older Python versions.
|
@jpmckinney I rebased my branch on |
|
Thank you! I’ll make a release when I’m at my desk. |
|
Released! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Python 3.9 a zoneinfo package is available in the standard library for this feature. There is therefore no need for this dependency and a compatibility layer is available at
https://pypi.org/project/backports.zoneinfo/ for older Python versions.
I made this change because agate is packaged in Fedora and Fedora is deprecating pytz: https://fedoraproject.org/wiki/Changes/DeprecatePytz