Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual install instructions for some UI frameworks #9526

Open
JusticeMatthew opened this issue Oct 2, 2024 · 1 comment
Open

Update manual install instructions for some UI frameworks #9526

JusticeMatthew opened this issue Oct 2, 2024 · 1 comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.

Comments

@JusticeMatthew
Copy link
Contributor

📚 Subject area/topic

Client-Side Interactivity

📋 Suggested page

https://docs.astro.build/en/guides/framework-components/

📋 General description or bullet points (if proposing new content)

The manual installation instructions for some UI frameworks do not include info about setting additional options in a ts.config when they are required (and are set by the astro CLI when using astro add)

As an example, when using npx astro add react the following is added to your TS config by the CLI:

  "compilerOptions": {
    "jsx": "react-jsx",
    "jsxImportSource": "react"
  }

However the manual installation instructions do not tell the user to add these options, which has resulted in issues for users.

🖥️ Reproduction of code samples in StackBlitz

No response

@JusticeMatthew JusticeMatthew added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Oct 2, 2024
@JusticeMatthew
Copy link
Contributor Author

I just wanted to get the issue opened, when I have some time today I will check and see which other frameworks adjust the TS config and post here what they add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

No branches or pull requests

1 participant