Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle different scenarios when setting a new UpdateEligibilityDelay #38

Open
garyghayrat opened this issue Oct 5, 2024 · 1 comment
Labels
calculator Tasks related to earning power calculator & oracle pre-audit Needed before the audit deadline todo Issues that need to be tackled pre-audit

Comments

@garyghayrat
Copy link
Collaborator

garyghayrat commented Oct 5, 2024

We should create an issue to think through what happens when this value is changed. I think it will cause problems, or at a minimum ambiguous situations. For example, if this is shortened, a bunch of scores immediately become qualified for updates. If it's lengthened, some scores may have updated that now wouldn't be qualified. We might need to switch to a model where the exact timestamp of the delay window ends is calculated and stored alongside score, based on whatever the delay is at the time of the update the makes it ineligible. But we don't have to tackle that here, we can think through it more carefully.

Originally posted by @apbendi in #24 (comment)

@garyghayrat garyghayrat added todo Issues that need to be tackled pre-audit pre-audit Needed before the audit deadline calculator Tasks related to earning power calculator & oracle labels Oct 5, 2024
@garyghayrat
Copy link
Collaborator Author

garyghayrat commented Oct 15, 2024

Keeping track of the delay window for the rare case of the delay period changing feels a bit excessive. I think the example you gave fits the expectation of what should happen if the eligibilityDelay was updated, and the new delay not taking effect for certain delegates might cause more confusion imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calculator Tasks related to earning power calculator & oracle pre-audit Needed before the audit deadline todo Issues that need to be tackled pre-audit
Projects
None yet
Development

No branches or pull requests

1 participant