Add tests to simulate issue 7739. #460
Conversation
cpuwzd
force-pushed
the
Issue7739
branch
2 times, most recently
from
65625d6 to
37250e8
Compare
|
Assuming that this pull request is still active, I'm ready for another review. This issue turned out to be considerably larger than first thought. The issue boils down to, "What do you want to know about the inner text?" The processing of inner text has been rethought in every scenario I could come up with. We could still use some more realistic test cases. |
Generalize the issue to apply to most situations in which inner text is used in Wix 3 to represent condidtions. These all suffer from the mishandling of whitespace. Review other uses of inner text amd pay attention to the treatment of CTEXT nodes.
Stopped escaping single and double quotes, as well as backslashes when converting inner text to attributes. Eliminated all out parameters of TryGetInnerText in favor of using a context parameter.
| private class InnerTextContext | ||
| { | ||
| internal string Value { get; set; } = null; | ||
| internal List<XNode> comments = null; |
There was a problem hiding this comment.
I'd just initialize the Comments property and get rid of this private field. As soon as Comments is accessed it creates the list so there isn't a huge savings not creating it up front.
| internal bool CoalesceWhitespace { get; set; } = true; | ||
| internal bool ReportWhitespace { get; set; } = false; | ||
|
|
||
| internal InnerTextContext() |
There was a problem hiding this comment.
Empty constructors are default and not needed. If you do need a constructor, it goes after the fields but before the property declarations.
Generalize the issue to apply to most situations in which inner text is used in Wix 3 to represent condidtions. These all sufferfrom the mishandling of whitespace othere than the space character gets converted into an attribute value.
The XML parser generally treats all white space the same and reduces contiguous white space to a single space character.
All condition expressions are reduced to single line expressions. The user is free to reformat his conveerted code by inserting white space characters for the optimum readability readability.
The ne