Resolve issues with inner text #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I really like this refactor. |
Generalize the issue to apply to most situations in which inner text is used in Wix 3 to represent condidtions. These all suffer from the mishandling of whitespace. Review other uses of inner text amd pay attention to the treatment of CTEXT nodes.
Stopped escaping single and double quotes, as well as backslashes when converting inner text to attributes. Eliminated all out parameters of TryGetInnerText in favor of using a context parameter.
A nearly stateless class and distinct methods now handle the three scenarios encountered so far.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wixtoolset/issues#7739