Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build Requirements #474

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Update Build Requirements #474

merged 1 commit into from
Dec 19, 2023

Conversation

chrpai
Copy link
Contributor

@chrpai chrpai commented Dec 6, 2023

Issue 7388

Testing of the developer build on a clean VM has indicated to me that .NET 3.5 SP1 is needed and git.exe has to be in the command path for the gitinfo tasks to work. This can be one of several distros or the one optionally provided by VS.

I also noted that spectre mitigated libs are available but I haven't touched that part of the recommendation as I don't know the strategy there.

I kind of wanted to put a couple lines in there saying last tested on 12/5/2023 using VS 17.8.3 to help future developers troubleshooting issues but I don't know if the maintainers would want that.

Issue 7388

Update README.md

Add .NET 6.0 to list of components
@robmen
Copy link
Member

robmen commented Dec 12, 2023

What required .NET v3.5?

@chrpai
Copy link
Contributor Author

chrpai commented Dec 12, 2023

@robmen DTF
image

@ViktorHofer
Copy link

ViktorHofer commented Dec 18, 2023

Do you really still need to target .NET Framework 2.0 for wix v4?

@chrpai
Copy link
Contributor Author

chrpai commented Dec 18, 2023

@ViktorHofer what do you mean? I'm only documenting what WiX is currently needing.

@robmen Do I need to do anything else to nudge this PR along?

@robmen robmen enabled auto-merge (rebase) December 18, 2023 23:44
@robmen robmen merged commit 7b63b09 into wixtoolset:develop Dec 19, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants