Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement virtual symbols and WiX Standard Library #475

Merged
merged 7 commits into from
Dec 16, 2023
Merged

Implement virtual symbols and WiX Standard Library #475

merged 7 commits into from
Dec 16, 2023

Conversation

robmen
Copy link
Member

@robmen robmen commented Dec 16, 2023

@robmen robmen force-pushed the robmen/virtual-symbols branch from 8b8313c to 92119c8 Compare December 16, 2023 18:24
@robmen
Copy link
Member Author

robmen commented Dec 16, 2023

@barnson please, please, please review my error messages. I struggled so much trying to generate useful English.

@barnson
Copy link
Member

barnson commented Dec 16, 2023

:shipit: Minor language tweaks.

@robmen
Initial support for virtual symbols.
06883a7 
Completes 7913
@robmen
Introducing the WiX Standard Library
5fe2704 
Completes 7914
@robmen
Improve error reporting of duplicate symbols
072b7c6 
Virtual symbols provide more interesting ways to have (and avoid) conflicts.
Adding additional messages and cleaning up the existing messages should help
users know what options they have to address conflicts.

This also puts all the conflict resolution in ReportConflictingSymbolsCommand
instead of spreading it across reference resolution as well.
@robmen
Copy link
Member Author

robmen commented Dec 16, 2023

@barnson does the :shipit: mean overall this is good to go (with the deleting of dead code)? Or are you still reviewing?

@barnson
Copy link
Member

barnson commented Dec 16, 2023

GtG with messages.

@robmen robmen force-pushed the robmen/virtual-symbols branch from 92119c8 to 072b7c6 Compare December 16, 2023 21:44
@robmen robmen enabled auto-merge (rebase) December 16, 2023 21:44
@robmen robmen merged commit 0bf10d9 into develop Dec 16, 2023
2 checks passed
@robmen robmen deleted the robmen/virtual-symbols branch December 16, 2023 22:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barnson barnson barnson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WiX Standard Library Virtual Symbols
2 participants
@robmen @barnson