Support naked files. #479
Merged
Support naked files. #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnson
force-pushed
the
bob/NakedFileEx
branch
from
0932858 to
534ec7b
Compare
|
Added: Components and naked Files default to being installed to INSTALLFOLDER |
robmen
reviewed
Jan 8, 2024
src/wix/WixToolset.Core/Compiler.cs
Outdated
| string condition = null; | ||
| string subdirectory = null; | ||
|
|
||
| var keyPath = this.ParseFileElementAttributes(node, "TemporaryComponentId", directoryId, diskId: CompilerConstants.IntegerNotSet, sourcePath, out var _, componentGuid: "*", isNakedFile: true, out var fileSymbol, out var assemblySymbol); |
There was a problem hiding this comment.
How about setting this to an invalid Id like "@WixTempComponentId"? That way, if it ever sneaks through too far into the build process, an error will occur.
Implements wixtoolset/issues#7696. `File` elements can appear where `Component` elements do in WiX v4. The compiler generates an appropriate per-file component. Naked files under `Directory`, `DirectoryRef`, `Fragment`, `StandardDirectory`, or `Package` elements are included in a package via the [default-feature feature](wixtoolset/issues#7581). Naked files appearing under `ComponentGroup`, `Feature`, `FeatureRef`, and `FeatureGroup` generate the component and the reference to the parent element. Components and naked Files default to being installed to INSTALLFOLDER (including a default INSTALLFOLDER if one isn't otherwise authored).
barnson
force-pushed
the
bob/NakedFileEx
branch
from
534ec7b to
50c0f7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements wixtoolset/issues#7696.
Fileelements can appear whereComponentelements do in WiX v4. The compiler generates an appropriate per-file component. Naked files underDirectory,DirectoryRef,Fragment,StandardDirectory, orPackageelements are included in a package via the default-feature feature. Naked files appearing underComponentGroup,Feature,FeatureRef, andFeatureGroupgenerate the component and the reference to the parent element.Components and naked Files default to being installed to INSTALLFOLDER
(including a default INSTALLFOLDER if one isn't otherwise authored).