Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] search & filter bar javascript logic #10

Open
serapath opened this issue Jan 13, 2018 · 2 comments
Open

[feature] search & filter bar javascript logic #10

serapath opened this issue Jan 13, 2018 · 2 comments

Comments

@serapath
Copy link
Member

serapath commented Jan 13, 2018

to make the search & filter bar do something

This was referenced Jan 13, 2018
@serapath serapath changed the title search & filter bar javascript logic feature: search & filter bar javascript logic Jan 20, 2018
@serapath serapath changed the title feature: search & filter bar javascript logic search & filter bar javascript logic Jan 20, 2018
@serapath serapath changed the title search & filter bar javascript logic [feature] search & filter bar javascript logic Jan 20, 2018
@jameslin3263
Copy link

jameslin3263 commented Feb 14, 2018

Hi, I finally finished it, Sorry for the delay
It still needs to filter the duplication of the reports, which had been fetch. I will try to find out the solution to solve it.
Additionally, I haven't done some CSS in this component, so if anyone has some ideas maybe we can try these
https://github.com/jameslin3263/Amigo-search-bar-issue
@serapath @ninabreznik @kiecoo @TzuYuanLiu

@serapath
Copy link
Member Author

@jameslin3263 very nice.
I would recommend you to make an index.html in your github repository and activate github page under "Settings".

Then - on your github repo, you can edit the title description and a link that describes your repository, so people can click the link (which would link to the github page of your repo) to see a little demo or preview. If you do everything right, the link will be: (https://jameslin3263.github.io/Amigo-search-bar-issue)

Inside of the index.html you just use the npm-require script tag and then require your own module by writing: var searchbar = require('./src/index.js') ..that might just work.

But I didn't check your code in detail and see that you use a service worker too. But once you have the github page, you can ping me and i try to help debugging :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants