-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commands: indicate in listcoins
response whether coin is from self
#1483
Open
jp1ac4
wants to merge
7
commits into
wizardsardine:master
Choose a base branch
from
jp1ac4:store-coin-is-from-self
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 22, 2024
-
sqlite: refactor migration tests
Some migration tests used structs and methods that are expected to change and so will not be backward compatible. This change replaces those with structs and methods specific to the migration tests so that the tests will be unaffected by DB schema changes. At the same time, these new structs and methods simplify some of the setup by allowing to store new coins, including their confirmation and spend status, in a single DB operation.
Configuration menu - View commit details
-
Copy full SHA for bde3299 - Browse repository at this point
Copy the full SHA bde3299View commit details
Commits on Nov 28, 2024
-
sqlite: refactor test to not depend on order of coins
I found that making changes to the transactions used in the test can affect the order in which coins are returned, probably due to the txid changing.
Configuration menu - View commit details
-
Copy full SHA for f2c910f - Browse repository at this point
Copy the full SHA f2c910fView commit details -
sqlite: add columns to transactions and coins tables
The new columns in the transactions table will be populated for new transactions by the poller, while existing rows will be updated in a subsequent migration. New and existing coins will all have `is_from_self` set to false due to the default column value. None of these columns will be used by the wallet at this stage.
Configuration menu - View commit details
-
Copy full SHA for 4f6dcbf - Browse repository at this point
Copy the full SHA 4f6dcbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for da18536 - Browse repository at this point
Copy the full SHA da18536View commit details -
database: track whether coin is from self
This populates the new columns from the previous migration for existing rows and then maintains them in the poller moving forward.
Configuration menu - View commit details
-
Copy full SHA for 22774c6 - Browse repository at this point
Copy the full SHA 22774c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6db2599 - Browse repository at this point
Copy the full SHA 6db2599View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16726f5 - Browse repository at this point
Copy the full SHA 16726f5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.