Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: indicate in listcoins response whether coin is from self #1483

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Nov 22, 2024

  1. sqlite: refactor migration tests

    Some migration tests used structs and methods that are expected
    to change and so will not be backward compatible.
    
    This change replaces those with structs and methods specific to
    the migration tests so that the tests will be unaffected by DB
    schema changes. At the same time, these new structs and methods
    simplify some of the setup by allowing to store new coins,
    including their confirmation and spend status, in a single
    DB operation.
    jp1ac4 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    bde3299 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. sqlite: refactor test to not depend on order of coins

    I found that making changes to the transactions used in the test
    can affect the order in which coins are returned, probably due
    to the txid changing.
    jp1ac4 committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f2c910f View commit details
    Browse the repository at this point in the history
  2. sqlite: add columns to transactions and coins tables

    The new columns in the transactions table will be populated for
    new transactions by the poller, while existing rows will be
    updated in a subsequent migration.
    
    New and existing coins will all have `is_from_self` set to false
    due to the default column value.
    
    None of these columns will be used by the wallet at this stage.
    jp1ac4 committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    4f6dcbf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da18536 View commit details
    Browse the repository at this point in the history
  4. database: track whether coin is from self

    This populates the new columns from the previous migration
    for existing rows and then maintains them in the poller moving
    forward.
    jp1ac4 committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    22774c6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6db2599 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    16726f5 View commit details
    Browse the repository at this point in the history