Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bubble up errors from the Bitcoin interface instead of panic'ing there #909

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Bubble up errors from the Bitcoin interface instead of panic'ing there #909

wants to merge 11 commits into from

Commits on Jan 11, 2024

  1. poller: make the updating process into its own function.

    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    65f87ab View commit details
    Browse the repository at this point in the history

  2. poller: hold the same database lock across one update round

    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    bdbedb8 View commit details
    Browse the repository at this point in the history

  3. lib: externalize the Bitcoin poller thread handling 

    The caller is now responsible for running the poller in a thread.
    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d8c59e3 View commit details
    Browse the repository at this point in the history

  4. lib: add a TODO to harmonize the interface of the JSONRPC server with… 

    … the Bitcoin poller

We won't do it here to avoid further increasing a large diff.
    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    706b7ee View commit details
    Browse the repository at this point in the history

  5. bitcoind: make all node requests faillible 

    For now this just moves the expect()s one layer up.
    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    82bec1e View commit details
    Browse the repository at this point in the history

  6. bitcoind: make wallet requests fallible 

    Same as previous commit but for wallet requests
    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    9d5c0bf View commit details
    Browse the repository at this point in the history

  7. bitcoind: make get_block_hash return a result 

    It's less straightforward for calls which return a JSONRPC error on not found
    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    236af57 View commit details
    Browse the repository at this point in the history

  8. bitcoind: don't panic in mempool_entry, propagate the error

    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    21c9f16 View commit details
    Browse the repository at this point in the history

  9. bitcoind: don't ignore unexpected error in get_transaction

    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5664a79 View commit details
    Browse the repository at this point in the history

  10. bitcoin: propagate errors occuring in our Bitcoin backend interface

    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    fb768e0 View commit details
    Browse the repository at this point in the history

  11. bitcoind: remove most expect()'s for invalid fields, propagate errors.

    @darosior
    darosior committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    72920b2 View commit details
    Browse the repository at this point in the history