Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On windows read locked file can be written to #98

Open
adalfarus opened this issue Nov 29, 2024 · 2 comments
Open

On windows read locked file can be written to #98

adalfarus opened this issue Nov 29, 2024 · 2 comments

Comments

@adalfarus
Copy link

You need to use msvcrt like file locker to create a hard lock

@adalfarus
Copy link
Author

Pycharm for example can still write to a read locked file even though it tells you it's locked

@github-actions github-actions bot added the Stale label Dec 30, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2025
@wolph wolph reopened this Jan 6, 2025
@wolph wolph removed the Stale label Jan 6, 2025
@wolph
Copy link
Owner

wolph commented Jan 6, 2025

The stale bot unfortunately closes stuff too fast at times, sorry about that.

The library used to use msvcrt for locking, but that had some different issues: #64
You can see the diff here:
89e2e32

Would it be possible for you to verify that the old version (i.e. 2.4.0 or lower) works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants