-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#4/create-your-card #43
Conversation
✔️ Deploy Preview for scrollodex ready! 🔨 Explore the source changes: 73ad1ec 🔍 Inspect the deploy log: https://app.netlify.com/sites/scrollodex/deploys/6169c8ba9642980007a8cf79 😎 Browse the preview: https://deploy-preview-43--scrollodex.netlify.app/ |
Your card looks amazing @KesineeP ! 💟 |
Hi I fixed the error by adding rel="noreferrer" and fixed the conflicts. My question is what do i do next? Do I close this PR and open new PR or any way i can edit this PR? |
Should be the same as normal, push to your branch you created the pull request from and it should be automatically pull changes in here @KesineeP 😄 |
Actually, I see your changes @KesineeP , but the netlify log here: https://app.netlify.com/sites/scrollodex/deploys/61698b117f50b8000837e668 says the build is failing to compile because there are multiple card imports of the same name, I would just edit the file to have one instance of that card import and it should be good to go and I can merge it after |
Sorry for all the trouble. I just push new commit. Hopefully, It works this time. Thank you for your help :) |
Thanks @KesineeP ! You're awesome! |
#4
Added my card