Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#4/create-your-card #43

Merged
merged 9 commits into from
Oct 15, 2021
Merged

Conversation

KesineeP
Copy link
Contributor

#4
Added my card
Screen Shot 2021-10-14 at 8 45 22 PM

@netlify
Copy link

netlify bot commented Oct 15, 2021

✔️ Deploy Preview for scrollodex ready!

🔨 Explore the source changes: 73ad1ec

🔍 Inspect the deploy log: https://app.netlify.com/sites/scrollodex/deploys/6169c8ba9642980007a8cf79

😎 Browse the preview: https://deploy-preview-43--scrollodex.netlify.app/

@domsbytes domsbytes self-requested a review October 15, 2021 03:46
src/cards/kesineeCard/KesineeCard.jsx Show resolved Hide resolved
src/cardsDisplay.jsx Show resolved Hide resolved
@domsbytes
Copy link
Member

Your card looks amazing @KesineeP ! 💟

@KesineeP
Copy link
Contributor Author

Hi I fixed the error by adding rel="noreferrer" and fixed the conflicts. My question is what do i do next? Do I close this PR and open new PR or any way i can edit this PR?

@domsbytes
Copy link
Member

domsbytes commented Oct 15, 2021

Should be the same as normal, push to your branch you created the pull request from and it should be automatically pull changes in here @KesineeP 😄

@domsbytes
Copy link
Member

domsbytes commented Oct 15, 2021

Actually, I see your changes @KesineeP , but the netlify log here: https://app.netlify.com/sites/scrollodex/deploys/61698b117f50b8000837e668

says the build is failing to compile because there are multiple card imports of the same name, I would just edit the file to have one instance of that card import and it should be good to go and I can merge it after

@KesineeP
Copy link
Contributor Author

Sorry for all the trouble. I just push new commit. Hopefully, It works this time. Thank you for your help :)

@mjordancodes mjordancodes merged commit b61f1e7 into women-who-software:main Oct 15, 2021
@domsbytes
Copy link
Member

Thanks @KesineeP ! You're awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants