Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No license information available #588

Closed
ideasman42 opened this issue Sep 7, 2017 · 5 comments
Closed

No license information available #588

ideasman42 opened this issue Sep 7, 2017 · 5 comments

Comments

@ideasman42
Copy link

ideasman42 commented Sep 7, 2017

No licensing information is available, checked readme and contributing documents.

Note that 3rd party dependencies: fountain, jsBezier and three.min are MIT.

@cg-cnu
Copy link

cg-cnu commented Sep 7, 2017

Hey @ideasman42 Good to see you here... 😄

The package.json says its "license": "ISC",. Yep, most of the deps are MIT. I might be wrong but both ISC and MIT share the same principles. 🤔

@setpixel Any reason for choosing ISC over MIT ?

@Fweeb
Copy link

Fweeb commented Sep 7, 2017

@cg-cnu I think the point was that there's not a clear LICENSE file in the root of the source or a mention of the license in the readme or contributing files, as per convention. It's nice that it's at least somewhat covered in the package.json file, but folks shouldn't really have to dig through that file just to find out what license is being used.

@cg-cnu
Copy link

cg-cnu commented Sep 7, 2017

Hey @Fweeb, Wooow... happy to meet all of you folks here... 😄
True, I agree. Its hidden a little inside. I just did a pr adding that to readme. 🙂

@satishgoda
Copy link

There is a discussion going on at #567

@ideasman42 ideasman42 mentioned this issue Sep 9, 2017
@audionerd
Copy link
Member

Duplicate of #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants