Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates WooCommerce.com links to Woo.com #2132

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Updates WooCommerce.com links to Woo.com #2132

merged 4 commits into from
Jan 12, 2024

Conversation

jeffikus
Copy link
Contributor

Updates all instances of WooCommerce.com links in both the wp-admin and frontend. This includes the developer composer and package files, readme, and language files.

Fixes request from @kevinbates as per p1704919648335339-slack-C02PXDRC67P

How to test the changes in this Pull Request:

  1. Install and activate Storefront.
  2. Navigate to /wp-admin/themes.php?page=storefront-welcome and check if outbound links point to woo.com instead of woocommerce.com
  3. Navigate to /wp-admin/themes.php?theme=storefront and check if outbound links point to woo.com instead of woocommerce.com
  4. Navigate to the frontend of your website and check that the "Built with Storefront." link navigate to the product page on woo.com correctly.

Changelog

Fix – Updates wp-admin and frontend credit links to point to Woo.com instead of WooCommerce.com

@jeffikus
Updates WooCommerce.com links to Woo.com
86c1165 
Updates all instances of WooCommerce.com links in both the wp-admin and frontend. This includes the developer composer and package files, readme, and language files.
danielwrobert
danielwrobert approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@danielwrobert danielwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one non-blocking comment about the footer note.

Aside from that, I spot-tested the new URLs to confirm they point to working pages.

Everything LGTM! 🚀

inc/storefront-template-functions.php Outdated
@@ -139,9 +139,9 @@ function storefront_credit() {

if ( apply_filters( 'storefront_credit_link', true ) ) {
if ( storefront_is_woocommerce_activated() ) {
$links_output .= '<a href="https://woocommerce.com" target="_blank" title="' . esc_attr__( 'WooCommerce - The Best eCommerce Platform for WordPress', 'storefront' ) . '" rel="noreferrer nofollow">' . esc_html__( 'Built with Storefront &amp; WooCommerce', 'storefront' ) . '</a>.';
$links_output .= '<a href="https://woo.com" target="_blank" title="' . esc_attr__( 'WooCommerce - The Best eCommerce Platform for WordPress', 'storefront' ) . '" rel="noreferrer nofollow">' . esc_html__( 'Built with Storefront &amp; WooCommerce', 'storefront' ) . '</a>.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but it was recommended to also update this text to read:

Built with WooCommerce.

The reasoning was that it simplifies the text, and puts the emphasis on WooCommerce, with the URL pointing to our new landing page for WooCommerce.

See this thread for context: p1704919987116639/1704919648.335339-slack-C02PXDRC67P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I missed that. Updated now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the language pot file as well.

Copy link
Contributor

@danielwrobert danielwrobert Jan 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also notice the E2E tests were failing because of the change to the text in the footer credit.

I took the liberty to update the test (in be6292d) to look for the updated output. Tests are passing now.

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Jan 11, 2024
jeffikus and others added 3 commits January 11, 2024 18:24
@jeffikus
Updates footer credit.
e3c3946 
Changes footer credit from:
"Built with Storefront & WooCommerce."
To
"Built with WooCommerce."
@jeffikus
Updates language file.
b841787 
Updates language file with new footer credit string.
@danielwrobert
Update E2E test for footer credit to reflect changes.
be6292d
@danielwrobert danielwrobert merged commit 5185bec into trunk Jan 12, 2024
7 checks passed
@danielwrobert danielwrobert deleted the update/url-changes branch January 12, 2024 02:38
@danielwrobert danielwrobert removed the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Jan 12, 2024
@danielwrobert danielwrobert self-assigned this Jan 12, 2024
@dinhtungdu dinhtungdu added this to the 4.5.4 milestone Jan 16, 2024
@danielwrobert danielwrobert mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwrobert danielwrobert danielwrobert approved these changes

Assignees

@danielwrobert danielwrobert

Labels
None yet
Projects
None yet
Milestone
4.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffikus @danielwrobert @dinhtungdu