Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web tool : simulation never goes through #881

Open
Critxtth opened this issue Jul 27, 2024 · 8 comments
Open

Web tool : simulation never goes through #881

Critxtth opened this issue Jul 27, 2024 · 8 comments

Comments

@Critxtth
Copy link

Describe the bug

First of all thanks a lot for your work, wowsims is a great app 💕
I've been using your web tool since the begginning of WOTLK and never came accross any issue.
Very recently, I've been trying to sim my chars, but the simulation never ends. It stops in the middle of the iterations, and doesn't show real DPS. I havent touched any settings, and it happens on every class/spec that I try to sim.
I tried different web browsers, private navigation, doesn't fix the problem.
The video of the issue is available here :
https://medal.tv/games/pc-simulator/clips/ilVYHgJTpcsEu1APL/d1337VaNi1pD?invite=cr-MSw4eFAsMzk5NTIzNiw

To Reproduce
Steps to reproduce the behavior:

  1. Go to web tool
  2. Select any spec (I tested fire mage, combat rogue, shadow priest)
  3. Launch sim
  4. See error

Expected behavior
Finish the job and display real DPS

Sim Links and Screenshots
If applicable, add links to your sim settings or screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Brave, Edge
  • Latest versions

Additional context
Add any other context about the problem here.

@FelixPflaum
Copy link
Contributor

Does the browser console show errors?
Does it still happen if you set the worker count to 0 (the cog button top right, set "Use Multiple CPU Cores" to off)?

@Critxtth
Copy link
Author

Critxtth commented Jul 27, 2024

  • Does the browser console show errors?

Here is he output on the console :

image

Uncaught (in promise) TypeError: WebAssembly compilation aborted: Network error: Response body loading was aborted
Promise.then
(anonymous) @ sim_worker.js:617

  • Does it still happen if you set the worker count to 0 (the cog button top right, set "Use Multiple CPU Cores" to off)?

It seems like it fixes the problem indeed. Mine was set to 4, I turned it off and it worked again. It seems like it works for value = Off, or 2, but doesn't work for the values above.

But thatll do it for me, thanks for your fast answer ! You can close the issue if you want. 👍 💕

@FelixPflaum
Copy link
Contributor

Not sure if that is a bug with the site or with your network/browser. But in any case an error like that should be handled and not cause the sim to just get stuck for the user. Therefore this should stay open until that is resolved.

@dexxiez
Copy link
Contributor

dexxiez commented Jul 29, 2024

#885 related?

@rosenrusinov
Copy link
Contributor

#885 related?

Most likely yes

@FelixPflaum
Copy link
Contributor

FelixPflaum commented Jul 29, 2024

#885 related?

Most likely yes

No, that's an actual sim error. Here the lib.wasm isn't loaded so the worker doesn't even do anything, and there's no error handling for that atm. And because of that the concurrency code sends partial work to dysfunctional workers and never gets an error back, so it just gets stuck visually waiting for progress.

@Caldorwow
Copy link

Having the same issue after downloading the Local SIM. Even after I deleted it it is still doing it.

@FelixPflaum
Copy link
Contributor

@Caldorwow It just gets stuck without showing any error? Could you provide an export link of your settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants