Improved plugins template and new PHPCS rules #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- File header with new entries. - Modified the namespace. - Replaced the `or` statement by `||`. - Put the `add_action()` before the function. - Added a `@since` tag to the function DocBlock.
hellofromtonya
suggested changes
Jan 14, 2020
optimization/imagify-bulk-buffer-size/imagify-bulk-buffer-size.php
Outdated
Show resolved
Hide resolved
optimization/imagify-reset-optimization-status/imagify-reset-optimization-status.php
Outdated
Show resolved
Hide resolved
settings/imagify-capacity-bulk-optimize/imagify-capacity-bulk-optimize.php
Outdated
Show resolved
Hide resolved
optimization/imagify-bulk-buffer-size/imagify-bulk-buffer-size.php
Outdated
Show resolved
Hide resolved
optimization/imagify-no-auto-optimize-pdf/imagify-no-auto-optimize-pdf.php
Outdated
Show resolved
Hide resolved
- Added vendor to namespaces - Removed `@package` tags since they are redundent with namespaces. Also added the related phpcs exclusion in phpcs.xml. - Fixed `CamelCase` => `PascalCase` in general README. - Removed useless priority + number of args in a filter in "Change Bulk Buffer Size" helper.
hellofromtonya
approved these changes
Jan 15, 2020
remyperona
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.