Preserve the box rocket_activation_notice with update

[engahmeds3ed]

Description

Preserve the box rocket_activation_notice with update.

Fixes #5889

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

• My code follows the style guidelines of this project, with adapted comments and without new warnings.
• I have added unit and integration tests that prove my fix is effective or that my feature works.
• The CI passes locally with my changes (including unit tests, integration tests, linter).
• Any dependent changes have been merged and published in downstream modules.
• If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
• I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

[Mai-Saad]

@engahmeds3ed Thanks for the PR. Please find exploratory test notes below:
1- If we dismiss the notice then deactivate WPR and activate WPR again. Notice will be displayed.
2- If we update from the previous version to the PR without dismissing notice before the update. it will be automatically dismissed.

[engahmeds3ed]

@engahmeds3ed Thanks for the PR. Please find exploratory test notes below: 1- If we dismiss the notice then deactivate WPR and activate WPR again. Notice will be displayed. 2- If we update from the previous version to the PR without dismissing notice before the update. it will be automatically dismissed.

Good catch, based on the current code yes this is expected after checking this old code.
Let me try fixing that without affecting other boxes.

[engahmeds3ed]

@Tabrisrp do u remember why do we clear all rocket boxes with update?

[remyperona]

I do not, it's something that was there before my time. It probably made sense at some point, but not anymore.

[engahmeds3ed]

Thanks @Tabrisrp

Summary: the used function we remove all dismissed notices for all users and only fire dismissing the following boxes with every update:

One or more plugins have been enabled or disabled, clear the cache if they affect the front end of your site.

and the second box is the activation notice.

Even if the user didn't dismiss both boxes, both will be dismissed based on the current code.

So based on the above discussion we have three solutions here:

1. Replace this code with a direct query to delete all user boxes and keep only the dismissed boxes but this is bad from performance point of view.
2. Don't remove all boxes with update at all and keep what's ignored kept ignored.
3. Accept the PR as is with the issues that @Mai-Saad mentioned above as known issues.

I believe we need the @wp-media/productrocket decision here.

[piotrbak]

@engahmeds3ed @Tabrisrp Do you see any reason why the boxes might be cleared? It doesn't seem to be making sense currently

[engahmeds3ed]

@engahmeds3ed @Tabrisrp Do you see any reason why the boxes might be cleared? It doesn't seem to be making sense currently

Really I don't know.

[piotrbak]

@engahmeds3ed Let's go with 2 then.

[Mai-Saad]

Scenario 2 here #6120 (comment) is fixed, while 1 is still there

[engahmeds3ed]

Thanks @Mai-Saad it should work now, can u plz also validate this old issue #5423 as it was touched here in this PR.

[Mai-Saad]

Working as expected now both 1,2 are fine