Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the box rocket_activation_notice with update #6120

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Preserve the box rocket_activation_notice with update #6120

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
874616c
keep the box rocket_activation_notice with update
engahmeds3ed Aug 28, 2023
5714cd7
don't clear rocket boxes at all with update
engahmeds3ed Sep 15, 2023
76f2687
renew preload notice box only with deactivation
engahmeds3ed Sep 19, 2023
d5b0c7c
Merge branch 'develop' into fix/5889-activation-notice-with-update
engahmeds3ed Sep 19, 2023
1226ab1
fix phpcs
engahmeds3ed Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/admin/upgrader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function rocket_upgrader() {
if ( did_action( 'wp_rocket_first_install' ) || did_action( 'wp_rocket_upgrade' ) ) {
flush_rocket_htaccess();

rocket_renew_all_boxes( 0, [ 'rocket_warning_plugin_modification' ] );
rocket_renew_all_boxes( 0, [ 'rocket_warning_plugin_modification', 'rocket_activation_notice' ] );

$options = get_option( WP_ROCKET_SLUG ); // do not use get_rocket_option() here.
$options['version'] = WP_ROCKET_VERSION;
Expand Down