Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/5987 lazyload css #6128

Merged
merged 20 commits into from
Aug 31, 2023
Merged

Feature/5987 lazyload css #6128

merged 20 commits into from
Aug 31, 2023

Conversation

CrochetFeve0251
Copy link
Contributor

@CrochetFeve0251 CrochetFeve0251 commented Aug 31, 2023

Description

Fix the js script and an issue with relative urls.

Fixes #5987

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • This change requires a documentation update.

Is the solution different from the one proposed during the grooming?

Please describe in this section if there is any change to the groomed solution, and why.

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@CrochetFeve0251 CrochetFeve0251 self-assigned this Aug 31, 2023
@CrochetFeve0251 CrochetFeve0251 marked this pull request as ready for review August 31, 2023 10:30
Copy link
Contributor

@engahmeds3ed engahmeds3ed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @CrochetFeve0251 this will prevent the error but we need not to add the script when DONOTCACHEPAGE constant is set not to add the script in not cached pages.

@CrochetFeve0251 CrochetFeve0251 added this pull request to the merge queue Aug 31, 2023
Merged via the queue into develop with commit bc38579 Aug 31, 2023
8 checks passed
@CrochetFeve0251 CrochetFeve0251 deleted the feature/5987-lazyload-css branch August 31, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyLoad CSS Background Images
2 participants