Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7062 Fonts filesystem #7083

Merged

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Nov 1, 2024

Description

Add a working prototype for font optimisation backend filesystem

Fixes #7062

Type of change

Detailed scenario

N/A

Technical description

Documentation

This feature allow for the download of media fonts locally, it introduce a new namespace Media\Fonts with three new classes Fonts, Subscriber and Filesystem.
The method write_font_css accepts two arguments, the font url and the provider and use those information to download the font and store locally. When the Filesystem class is initialised there's a setter method to declare the version of the fonts

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Copy link

codacy-production bot commented Nov 1, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for a6e21f51 88.42% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a6e21f5) Report Missing Report Missing Report Missing
Head commit (fe13945) 38342 16829 43.89%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7083) 95 84 88.42%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal changed the base branch from develop to feature/3.18 November 5, 2024 09:35
@Khadreal Khadreal requested review from remyperona and a team November 6, 2024 22:16
@Khadreal Khadreal marked this pull request as ready for review November 11, 2024 14:27
@Khadreal Khadreal changed the base branch from feature/3.18 to feature/host-google-fonts November 11, 2024 14:27
@Khadreal Khadreal requested a review from remyperona November 15, 2024 13:06
@Khadreal Khadreal requested a review from jeawhanlee November 15, 2024 18:38
@remyperona remyperona changed the title Sub task/3.18 backend filesystem part#7062 Closes #7062 Fonts filesystem Nov 15, 2024
@remyperona remyperona added this to the 3.18 milestone Nov 15, 2024
@remyperona remyperona added the type: sub-task Indicates the issue is a sub-task linked to an epics card label Nov 15, 2024
@remyperona remyperona merged commit 3201ce5 into feature/host-google-fonts Nov 15, 2024
11 checks passed
@remyperona remyperona deleted the sub-task/3.18-backend-filesystem-part#7062 branch November 15, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.18 - Backend and filesystem part
3 participants