You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The field description output does basically always the same thing and could be abstracted in a method. If I'm not wrong, it currently does a slightly different thing only in the case of render_settings_field_radio() and render_settings_field_multibox().
The text was updated successfully, but these errors were encountered:
@afercia I completely agree, and there are more areas that are similar across all of these functions.
I think we should eventually create a base class and then individual classes for each field type. This would provide a much better and more reusable codebase, and would also allow us to set a proper visibility for utility methods such as what you're proposing.
I'd like to leave the code as is for now and not outsource such parts, so that we can focus on the markup/CSS/a11y challenges. Code quality can come after we know what exactly we wanna do and how we wanna do it. :)
The field description output does basically always the same thing and could be abstracted in a method. If I'm not wrong, it currently does a slightly different thing only in the case of
render_settings_field_radio()
andrender_settings_field_multibox()
.The text was updated successfully, but these errors were encountered: