Create impervious_surface.py #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiqi-tori
requested changes
Aug 28, 2024
| def get_data(self, bbox): | ||
| # load impervious_surface | ||
| dataset = ee.Image("Tsinghua/FROM-GLC/GAIA/v10").gt(0) # change_year_index is zero if permeable as of 2018 | ||
| imperv_surf = ee.ImageCollection(dataset |
There was a problem hiding this comment.
dataset needs to be forced to ImageCollection to apply the filterBounds() and other functions.
AttributeError: 'Image' object has no attribute 'filterBounds'
There was a problem hiding this comment.
Forced dataset to be imagecollection, and added test for impervious surface. (Not 100% sure I did that right.)
weiqi-tori
reviewed
Aug 29, 2024
tests/test_layers.py
Outdated
| @@ -77,6 +78,9 @@ def test_high_land_surface_temperature(): | |||
| data = HighLandSurfaceTemperature().get_data(BBOX_BRAZIL_LAURO_DE_FREITAS_1) | |||
| assert data.any() | |||
|
|
|||
| def test_impervious_surface(): | |||
| data = ImperviousSurface().get_data(BBOX_BRAZIL_LAURO_DE_FREITAS_1) | |||
| assert data.any() | |||
There was a problem hiding this comment.
Indent error cause test failed
|
The structure of |
weiqi-tori
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding layer for impervious surface from GEE Tsinghua dataset.