Skip to content
This repository has been archived by the owner on Dec 4, 2022. It is now read-only.

[REQ] Add status codes and error message to responses #7

Open
wslyvh opened this issue Aug 16, 2019 · 0 comments
Open

[REQ] Add status codes and error message to responses #7

wslyvh opened this issue Aug 16, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wslyvh
Copy link
Owner

wslyvh commented Aug 16, 2019

Is your feature request related to a problem? Please describe.
The Raiden API describes all expected responses and status codes for each call. The client only returns a generic error 'invalid response' right now.

Describe the solution you'd like
Include more descriptive error messages, incl. its status code to make troubleshooting more efficient.

E.g. for registering a token, the following responses can be expected:

  • 201 Created – A token network for the token has been successfully created.
  • 402 Payment Required – Insufficient ETH to pay for the gas of the register on-chain transaction
  • 404 Not Found – The given token address is invalid.
  • 409 Conflict – The token was already registered before, or The registering transaction failed.
  • 501 Not Implemented – Registering a token only works on testnet temporarily. On mainnet this error is returned.

See the Raiden API documentation: https://raiden-network.readthedocs.io/en/latest/rest_api.html

@wslyvh wslyvh added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant