Improve role management with shared role check #6010
+256
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
from
dfa1738
to
d382673
Compare
...rg.wso2.carbon.identity.api.resource.mgt.server.feature/resources/system-api-resource.xml.j2
Outdated
Show resolved
Hide resolved
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
from
d382673
to
83d38a5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6010 +/- ##
============================================
- Coverage 40.43% 40.27% -0.16%
- Complexity 14687 15340 +653
============================================
Files 1746 1757 +11
Lines 123017 125831 +2814
Branches 21841 21354 -487
============================================
+ Hits 49736 50675 +939
- Misses 65716 67659 +1943
+ Partials 7565 7497 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AnuradhaSK
reviewed
Oct 11, 2024
...ore/org.wso2.carbon.identity.core.server.feature/resources/resource-access-control-v2.xml.j2
Outdated
Show resolved
Hide resolved
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
from
83d38a5
to
8595831
Compare
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
2 times, most recently
from
9e6cb48
to
5ad6b1f
Compare
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
4 times, most recently
from
95c04a6
to
43662f9
Compare
AnuradhaSK
reviewed
Nov 14, 2024
...ole.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Nov 14, 2024
...ole.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java
Outdated
Show resolved
Hide resolved
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
9 times, most recently
from
6a157d4
to
bfaa53f
Compare
AnuradhaSK
reviewed
Nov 22, 2024
...ole.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java
Show resolved
Hide resolved
AnuradhaSK
reviewed
Nov 22, 2024
...ole.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java
Outdated
Show resolved
Hide resolved
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
from
bfaa53f
to
766c595
Compare
AnuradhaSK
reviewed
Nov 27, 2024
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Outdated
Show resolved
Hide resolved
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
from
766c595
to
cd0f737
Compare
AnuradhaSK
reviewed
Nov 28, 2024
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Nov 28, 2024
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Show resolved
Hide resolved
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
2 times, most recently
from
4229510
to
c43ff65
Compare
AnuradhaSK
reviewed
Nov 28, 2024
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Outdated
Show resolved
Hide resolved
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
from
c43ff65
to
e26d314
Compare
ShanChathusanda93
force-pushed
the
org-path-role-mgt-branch
branch
from
e26d314
to
da31fd0
Compare
|
AnuradhaSK
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request