Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve role permission extraction when roles are shared and not shared #6094

Merged

Conversation

ShanChathusanda93
Copy link
Contributor

Proposed changes in this pull request

[1] wso2-extensions/identity-inbound-provisioning-scim2#575
[2] wso2-extensions/identity-inbound-auth-oauth#2578

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@ShanChathusanda93 ShanChathusanda93 force-pushed the role-permission-impr-branch branch 2 times, most recently from 942e000 to 18c4acd Compare November 19, 2024 05:48
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.33%. Comparing base (c499ae8) to head (84bfd43).
Report is 256 commits behind head on master.

Files with missing lines Patch % Lines
...bon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6094      +/-   ##
============================================
- Coverage     40.64%   40.33%   -0.31%     
- Complexity    14463    15261     +798     
============================================
  Files          1763     1757       -6     
  Lines        117812   123927    +6115     
  Branches      19037    20787    +1750     
============================================
+ Hits          47881    49991    +2110     
- Misses        62641    66508    +3867     
- Partials       7290     7428     +138     
Flag Coverage Δ
unit 26.63% <88.88%> (+1.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 force-pushed the role-permission-impr-branch branch 2 times, most recently from f218f79 to 20b8d5a Compare November 21, 2024 04:29
@ShanChathusanda93
Copy link
Contributor Author

Quality Gate Failed Quality Gate failed

Failed conditions B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This failure mentioned about a repeting string in few error messages. Since this is an error message adding a constant to get a part of the message is not required. Hense we can skip this check and proceed.

Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12055306551

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12055306551
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12055306551

@ShanChathusanda93 ShanChathusanda93 merged commit 6289d27 into wso2:master Nov 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants