-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve role permission extraction when roles are shared and not shared #6094
Improve role permission extraction when roles are shared and not shared #6094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
942e000
to
18c4acd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6094 +/- ##
============================================
- Coverage 40.64% 40.33% -0.31%
- Complexity 14463 15261 +798
============================================
Files 1763 1757 -6
Lines 117812 123927 +6115
Branches 19037 20787 +1750
============================================
+ Hits 47881 49991 +2110
- Misses 62641 66508 +3867
- Partials 7290 7428 +138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ole.v2.mgt.core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java
Outdated
Show resolved
Hide resolved
f218f79
to
20b8d5a
Compare
This failure mentioned about a repeting string in few error messages. Since this is an error message adding a constant to get a part of the message is not required. Hense we can skip this check and proceed. |
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Outdated
Show resolved
Hide resolved
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Show resolved
Hide resolved
20b8d5a
to
0230fb4
Compare
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Outdated
Show resolved
Hide resolved
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Outdated
Show resolved
Hide resolved
...ole.v2.mgt.core/src/test/java/org/wso2/carbon/identity/role/v2/mgt/core/dao/RoleDAOTest.java
Outdated
Show resolved
Hide resolved
0230fb4
to
84bfd43
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12055306551
Proposed changes in this pull request
[1] wso2-extensions/identity-inbound-provisioning-scim2#575
[2] wso2-extensions/identity-inbound-auth-oauth#2578