Implement rule metadata service. #6148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6148 +/- ##
============================================
- Coverage 44.67% 40.18% -4.50%
- Complexity 13493 14781 +1288
============================================
Files 1578 1755 +177
Lines 98872 118699 +19827
Branches 16049 19847 +3798
============================================
+ Hits 44175 47701 +3526
- Misses 48073 63755 +15682
- Partials 6624 7243 +619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...data/src/main/java/org/wso2/carbon/identity/rule/metadata/provider/RuleMetadataProvider.java
Outdated
Show resolved
Hide resolved
malithie
force-pushed
the
rule-meta
branch
2 times, most recently
from
338cead
to
d197adf
Compare
| mapper.convertValue(value.get("value"), new TypeReference<Map<String, Object>>() { | ||
| }); | ||
|
|
||
| Value.InputType inputType = Value.InputType.valueOf(valueObject.get("inputType").toString().toUpperCase()); |
There was a problem hiding this comment.
"inputType"
Shall we define these as constants in the class ?
Comment on lines
+76
to
+78
| ERROR_DUPLICATE_FIELD("65002", "Duplicate field found.", | ||
| "Field: %s from metadata provider: %s already exists in the rule metadata."), | ||
| ; |
There was a problem hiding this comment.
Suggested change
| ERROR_DUPLICATE_FIELD("65002", "Duplicate field found.", | |
| "Field: %s from metadata provider: %s already exists in the rule metadata."), | |
| ; | |
| ERROR_DUPLICATE_FIELD("65002", "Duplicate field found.", | |
| "Field: %s from metadata provider: %s already exists in the rule metadata."); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Resolves wso2/product-is#21803
In order to populate the rule UI it should be possible to retrieve all fields and field value options that are needed to configure expressions.
This PR implements the core rule metadata service.
When should this PR be merged
Merging this PR releases the service component and the feature.
Feature will be bundled to the product over a separate PR. So note that merging this PR will not bundle the feature with the product.