-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do cert revocation improvement to validate with only one client certificate in the request when the issuer of that cert is present in the client trust store #2119
Merged
isudana
merged 10 commits into
wso2:master
from
Akila94:cert-revocation-synapse-improvement
Jan 29, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akila94
force-pushed
the
cert-revocation-synapse-improvement
branch
2 times, most recently
from
January 4, 2024 03:38
86bf9da
to
fc97e57
Compare
Akila94
changed the title
[WIP] Do cert revocation improvement to validate without the full cert chain in the request
Do cert revocation improvement to validate without the full cert chain in the request
Jan 4, 2024
Akila94
changed the title
Do cert revocation improvement to validate without the full cert chain in the request
Do cert revocation improvement to validate with only one client certificate in the request
Jan 4, 2024
Akila94
changed the title
Do cert revocation improvement to validate with only one client certificate in the request
Do cert revocation improvement to validate with only one client certificate in the request when the issuer of that cert is present in the client trust store
Jan 4, 2024
Akila94
commented
Jan 4, 2024
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Show resolved
Hide resolved
Akila94
commented
Jan 4, 2024
.../nhttp/src/main/java/org/apache/synapse/transport/certificatevalidation/cache/CertCache.java
Outdated
Show resolved
Hide resolved
Akila94
commented
Jan 4, 2024
...rts/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/config/TrustStoreHolder.java
Show resolved
Hide resolved
isudana
reviewed
Jan 19, 2024
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Show resolved
Hide resolved
Akila94
force-pushed
the
cert-revocation-synapse-improvement
branch
from
January 22, 2024 06:19
90a9d11
to
be79287
Compare
isudana
requested changes
Jan 23, 2024
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Show resolved
Hide resolved
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Show resolved
Hide resolved
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Outdated
Show resolved
Hide resolved
Akila94
force-pushed
the
cert-revocation-synapse-improvement
branch
from
January 23, 2024 05:10
be79287
to
09b48b3
Compare
isudana
reviewed
Jan 26, 2024
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Outdated
Show resolved
Hide resolved
Akila94
force-pushed
the
cert-revocation-synapse-improvement
branch
from
January 26, 2024 09:46
09b48b3
to
d02fc90
Compare
isudana
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This improvement contains the certificate revocation validation improvement so the validation can be done without the full certificate chain sent in the request.
The validation can also be done when only one intermediate client certificate is sent in the request. For this to happen the immediate issuer of that certificate should contain in the client trust store.
Also a cert cache (LRU) is implemented to keep the issuer certificate found after traversing the client trust store.
A data holder is introduced to avoid client trust store loading multiple times for a single server start-up.
One of the following configurations can be used to enable this improvement,
<transportReceiver name="https" class="org.apache.synapse.transport.passthru.PassThroughHttpMultiSSLListener">
.