-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cert revocation validation #2152
Merged
arunans23
merged 7 commits into
wso2:master
from
Akila94:cert-revocation-synapse-improvement-2
Mar 1, 2024
Merged
Improve cert revocation validation #2152
arunans23
merged 7 commits into
wso2:master
from
Akila94:cert-revocation-synapse-improvement-2
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akila94
force-pushed
the
cert-revocation-synapse-improvement-2
branch
from
February 27, 2024 08:38
fa9c7b0
to
bf474a0
Compare
Akila94
force-pushed
the
cert-revocation-synapse-improvement-2
branch
from
February 29, 2024 08:56
bf474a0
to
83a7566
Compare
arunans23
reviewed
Feb 29, 2024
.../java/org/apache/synapse/transport/certificatevalidation/CertificateVerificationManager.java
Outdated
Show resolved
Hide resolved
arunans23
approved these changes
Mar 1, 2024
This was referenced Mar 2, 2024
shilmyhasan
pushed a commit
to shilmyhasan/wso2-synapse-1
that referenced
this pull request
Aug 28, 2024
…v183.x-full Adding a new synapse property to disable MBean creation for Endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This improvement contains the certificate revocation validation improvement so the validation can be done without the full certificate chain sent in the request.
The validation can also be done when only one intermediate client certificate is sent in the request. For this to happen the immediate issuer of that certificate should contain in the client trust store.
Also a cert cache (LRU) is implemented to keep the issuer certificate found after traversing the client trust store.
One of the following configurations can be used to enable this improvement,
<transportReceiver name="https" class="org.apache.synapse.transport.passthru.PassThroughHttpMultiSSLListener">
.This also fixes the test failures that occurred in the issue: #2146