Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST: Anchoring Modals #3

Open
SwagUX opened this issue Feb 6, 2016 · 4 comments
Open

FEATURE REQUEST: Anchoring Modals #3

SwagUX opened this issue Feb 6, 2016 · 4 comments

Comments

@SwagUX
Copy link

SwagUX commented Feb 6, 2016

How hard would it be to create a single add on directive for Bootstrap.UI to use the Modal anchoring? I am to far into a project to use NG-Materialize, and have been looking for a directive that anchors modals as you have done. This is more of a request for a feature to use for Bootstrap.UI based on preexisting development work you have completed.

@wthomsen
Copy link
Owner

wthomsen commented Feb 7, 2016

It'll probably take more work than what you're hoping. That's why I released this library in the first place (although I've long since abandoned it and moved over to Angular Material myself).

As I say in the demo, ng-materialize is more or less just a conglomeration of my favorite bits from Materialize, Angular Material and UI Bootstrap. You could try pulling the code from components/modal. Keep in mind you'll also need ngAnimate and some extra CSS to make it all look right.

@SwagUX
Copy link
Author

SwagUX commented Feb 7, 2016

You wrote some really awesome code here. Angular Material is a huge framework, and honestly limits the people to a flat design. The components you wrote are actually great for people that want to extend on. I would really recommend you to at least market some of these components as Boostrap.UI extensions since Boostrap 4.0 isn't even out yet. You could really get some great references off of filling the gap of Boostrap.ui has. They aren't wishing to extend or add any more features on after I have filed requests for them.

How dependent are the modules you wrote on the core materialize script? Should it be pretty easy to just single out the modal feature?

@SwagUX
Copy link
Author

SwagUX commented Feb 7, 2016

Would you mind me making the modal into a Bootstrap.ui extended modal plugin based on the work you have done?

@wthomsen
Copy link
Owner

wthomsen commented Feb 7, 2016

You could probably pull out the modal without too much hassle. Again, you'll need to copy some CSS from the Materialize framework to make it look right.

I have no plans to make this a Bootstrap.ui plugin. It was meant to be an Angular solution for people wanting to use the Materialize framework. Unfortunately it stalled out when I made the switch to Angular Material myself. That said, feel free to fork and convert it yourself, if you think that's something people would find useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants