From 96d93850d83f9ee387c054f798adc0a89e92b032 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomek=20Nied=C5=BAwied=C5=BA?=
 <tomasz.niedzwiedz@wundermanthompson.com>
Date: Fri, 8 Apr 2022 18:18:19 +0200
Subject: [PATCH] Issue 228 remove explicit dependency on java plugin (#229)

issue #228 | Remove explicit dependency on Java plugin

It appears AEM Rules 1.5 caused an error when it was being uploaded to
the Marketplace. See:
https://community.sonarsource.com/t/new-release-aem-rules-1-5/61314/2

G Ann Campbell suggested that the `requirePlugins` metadata property
declaring a dependency on the Java plugin can be removed on the grounds
of Java analysis being an out-of-the-box feature.

Disable fail-fast strategy for builds across SonarQube versions so that all build even if one should fail, use latest images on top of specific versions
---
 .github/workflows/test-instalation.yml | 3 +++
 pom.xml                                | 1 -
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/test-instalation.yml b/.github/workflows/test-instalation.yml
index a6888ea..328ff7d 100644
--- a/.github/workflows/test-instalation.yml
+++ b/.github/workflows/test-instalation.yml
@@ -31,6 +31,9 @@ jobs:
         sonarqube-image:
           - 'sonarqube:8.9-community'
           - 'sonarqube:9.4-community'
+          - 'sonarqube:lts-community'
+          - 'sonarqube:latest'
+      fail-fast: false
     steps:
       # To use this repository's private action,
       # you must check out the repository
diff --git a/pom.xml b/pom.xml
index 410a470..80d3ce1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -362,7 +362,6 @@
           </pluginSourcesUrl>
           <pluginUrl>https://github.com/wttech/AEM-Rules-for-SonarQube</pluginUrl>
           <skipDependenciesPackaging>false</skipDependenciesPackaging>
-          <requirePlugins>java:6.15</requirePlugins>
           <sonarQubeMinVersion>8.9</sonarQubeMinVersion>
           <sonarLintSupported>true</sonarLintSupported>
         </configuration>