Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird issue with ‘nodes’ within the breadcrumb getting mixed up #139

Open
adamsilver opened this issue Mar 28, 2023 · 3 comments
Open
Labels
bug Something isn't working

Comments

@adamsilver
Copy link

https://cln.sh/R0CwRDGx

@paulrobertlloyd
Copy link
Collaborator

Hmmm, Eleventy’s navigation plugin is typically more convoluted and prone to breaking/errors than I’d like. It’s based on the concept of key names, which themselves are taken from page titles.

I think it might be possible to explicitly declare a parent node’s key name in this case… I’ll take a look and see if there’s a way to solve this already. If there is, I’ll update the documentation. If not, I’ll look at a way we can avoid this happening.

@paulrobertlloyd paulrobertlloyd added the bug Something isn't working label Jun 15, 2023
@vickytnz
Copy link
Contributor

vickytnz commented Aug 10, 2024

I've also experienced this issue when trying to create a site that will hopefully be part of the x-gov family. The home page doesn't act as expected on the homepage with the subsite - the breadcrumb is showing up for the current page and when I try to turn it off weird things happen.

On a check, this is also an issues with the plugin page itself

home page with breadcrumbs In this example the 'GOV.UK eleventy plugin' breadcrumb shouldn't be there (and it's causing a lot of repetition on the page).

I managed to hack this by making a template and putting everything into it

breadcrumbs: {
        classes: "govuk-!-display-none-print",
        items: [
            {
              text: options.parentSite.name,
              href: options.parentSite.url
            }
            ]
     }

@paulrobertlloyd
Copy link
Collaborator

Possibly fixed by #352.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants