Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mmp] Ignore, by default, frameworks that cause rejection from App Store. Fix #6039 #6107

Merged
merged 7 commits into from
May 23, 2019

Conversation

spouliot
Copy link
Contributor

So far this only applies to QTKit...

XM will now, by default, avoid natively link with QTKit unless it's
instructed to so explicitly using --link-prohibited-frameworks

ref: #6039

…ore. Fix xamarin#6039

So far this only applies to `QTKit`...

XM will now, by default, avoid natively link with QTKit unless it's
instructed to so explicitly using `--link-prohibited-frameworks`

ref: xamarin#6039
@spouliot
Copy link
Contributor Author

Can be validated with xamarin/SubmissionSamples#28

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

9 tests failed, 0 tests' device not found, 92 tests passed.

Failed tests

  • xammac tests/Mac/Release: BuildFailure
  • xammac tests/Mac/Release (all optimizations): BuildFailure
  • link all/Mac/Release: BuildFailure
  • link sdk/Mac/Release: BuildFailure
  • mono-native-compat/Mac Unified/Full: BuildFailure
  • mono-native-compat/Mac Unified/Modern: BuildFailure
  • mono-native-unified/Mac Unified/Full: BuildFailure
  • mono-native-unified/Mac Unified/Modern: BuildFailure
  • mmptest/macOS/NonSystem: Failed (Execution failed with exit code 7)

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests' device not found, 100 tests passed.

Failed tests

  • mmptest/macOS/NonSystem: Failed (Execution failed with exit code 2)

docs/website/mmp-errors.md Outdated Show resolved Hide resolved
docs/website/mmp-errors.md Outdated Show resolved Hide resolved
docs/website/mmp-errors.md Outdated Show resolved Hide resolved
docs/website/mmp-errors.md Outdated Show resolved Hide resolved
spouliot and others added 4 commits May 23, 2019 07:22
Co-Authored-By: Rolf Bjarne Kvinge <[email protected]>
Co-Authored-By: Rolf Bjarne Kvinge <[email protected]>
Co-Authored-By: Rolf Bjarne Kvinge <[email protected]>
Co-Authored-By: Rolf Bjarne Kvinge <[email protected]>
@spouliot
Copy link
Contributor Author

@rolfbjarne thanks for the typo fixes :) I need to figure out why textmate does not spot all of them :|

@monojenkins
Copy link
Collaborator

Build failure
Build failed or was aborted

Provisioning succeeded
🔥 Build failed 🔥

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 100 tests passed.

Failed tests

  • mmptest/macOS/NonSystem: Failed (Execution failed with exit code 2)

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 166 tests passed.

Failed tests

  • [xUnit] Mono BCL tests group 5/iOS Unified 32-bits - simulator/Debug: HarnessException (Harness exception for '[xUnit] Mono BCL tests group 5': System.NullReferenceException: Object reference not set to an instance of an object
    at xharness.AppRunner.TestsSucceeded (xharness.Log listener_log, System.Boolean timed_out, System.Boolean crashed) [0x0001e] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/AppRunner.cs:546
    at xharness.AppRunner.RunAsync () [0x01862] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/AppRunner.cs:886
    at xharness.RunSimulatorTask.RunTestAsync () [0x0026b] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/Jenkins.cs:3917
    at xharness.RunTestTask.ExecuteAsync () [0x00191] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/Jenkins.cs:3521
    at xharness.TestTask.RunInternalAsync () [0x00226] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/Jenkins.cs:2604 )
  • [xUnit] Mono SystemRuntimeCompilerServicesUnsafeXunit/watchOS 32-bits - simulator/Debug: Crashed
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed

@spouliot
Copy link
Contributor Author

@spouliot spouliot merged commit fc5b9e2 into xamarin:master May 23, 2019
@spouliot spouliot deleted the gh6039 branch May 23, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants