Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel build failed #423

Open
weipeng1999 opened this issue Sep 1, 2024 · 0 comments
Open

Fix wheel build failed #423

weipeng1999 opened this issue Sep 1, 2024 · 0 comments

Comments

@weipeng1999
Copy link

weipeng1999 commented Sep 1, 2024

when i try to build this package as a wheel for my system, i found that there is no submodules in final wheel file, that means the package only has 'init.py', in other words xskillscore.core, xskillscore.test and xskillscore.versioning are gone.
after some research, i found that it was because the item tool.setuptools.packages in pyproj.toml not be setted correctly, and I add a patch to build wheel successfully,
Please consider to merge the patch to fix wheel constrution:

diff --git a/pyproject.toml b/pyproject.toml
index 2ae2e11..9594ccb 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -72,7 +72,7 @@ repository = "https://github.com/xarray-contrib/xskillscore"
 documentation = "https://xskillscore.readthedocs.io/en/stable/"
 
 [tool.setuptools]
-packages = ["xskillscore"]
+packages = ["xskillscore", "xskillscore.core", "xskillscore.versioning"]
 
 [tool.setuptools_scm]
 fallback_version = "9999"

besides, here is my build environment:

>>> pip list | grep -e "\(setuptools\|installer\|build\|wheel\)"                                                                      (base)
build                         1.2.1
installer                     0.7.0
setuptools                    69.5.1
setuptools-scm                8.1.0
wheel                         0.44.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant