Make go-xcat pass ShellCheck #6367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samveen
changed the title
|
This will need to be rebased on top of master, so I'm marking it WIP till I get a chance to rebase. |
samveen
force-pushed
the
shellcheck_goxcat
branch
from
a2469aa
to
628007a
Compare
Signed-off-by: Samveen <[email protected]>
samveen
force-pushed
the
shellcheck_goxcat
branch
from
628007a
to
c4582a3
Compare
|
The rebase and additional checks are run and done. I've utilized the following commandline to check and test: Fixes for the checks SC2207 and SC2317 will required a drastic rewrite of go-xcat, for which I do not have the bandwidth right now. Maybe after six months. In the meantime, this is ready for testing and merging. |
samveen
changed the title
Obihoernchen
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Unfortunately this breaks go-xcat because of additional " chars.
current code:
[root@vm-test ~]# ./go-xcat install
Operating system: linux
Architecture: x86_64
Linux Distribution: almalinux
Version: 9.4
go-xcat Version: 1.0.53
Reading repositories ...... done
xCAT Core Packages
==================
Package Name Installed In Repository
------------ --------- -------------
perl-xCAT (not installed) 2.16.5-snap202303030907
xCAT (not installed) 2.16.5-snap202303030907
[...]
with this PR:
[root@vm-test ~]# ./go-xcat-new install
Operating system: linux
Architecture: x86_64
Linux Distribution: "almalinux"
Version: "9.4"
go-xcat-new: "almalinux": unsupported Linux distro
go-xcat-new Version: 1.0.53
Reading repositories ...... failed
Cache was expired
0 files removed
go-xcat-new: "almalinux""9: unsupported Linux distro
Cache was expired
0 files removed
Boo-boo
=======
Something went wrong. :(
Please check log file `/tmp/go-xcat.log' for more details.
|
I'll check on this. PLease give me a couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to partially fix issue #4610
The modification include
ShellChecks on go-xcat
The UT result