Implementation of different image formats #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Hi ahsand97, thanks for the pull request. |
Thanks, I didn't update the dependencies to the snap version cuz I didn't reallt know how to, so I believe the snap doesn't have the MagickWand dependency yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I think I implemented support to multiple formats using the ImageMagick high level C API, I already tested with .svg, .xpm, .ico, .png, .jpg and extensionless valid image and it works.
Demonstration:
Images used:
extensionless .svg file
.svg file
.png file
.xpm file
.jpg file (almost invisible but is the twitter one)
.ico file
PS: Also I refactored some code solving some warnings that Intellij CLion was suggesting.