Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownThemAll "Set file time to last modified time (server)" is broken #311

Closed
jiangzhenjerry opened this issue Aug 19, 2024 · 7 comments
Closed

Comments

@jiangzhenjerry
Copy link

jiangzhenjerry commented Aug 19, 2024

In the DownThemAll updated yesterday (welcome back btw!), "Set file time to last modified time (server)" is broken. The last modified time is not preserved, even though this option is selected.

1
@xiaoxiaoflood
Copy link
Owner

Couldn't reproduce it, tested here and it's working as expected, with this checkbox on and off.

Maybe it only affects Windows? I use Linux.

@xiaoxiaoflood
Copy link
Owner

Well, I just tested on W11 and it's working too...

@jiangzhenjerry
Copy link
Author

jiangzhenjerry commented Aug 19, 2024

I tested it in a clean Windows environment (inside Windows Sandbox) and with a clean Firefox profile. It only "sometimes" works. I cannot identify the pattern yet. Below shows one example. What I did

  1. Open Firefox, navigate to a page under https://ftp.mozilla.org/
  2. Download a random file from there. It works - the file timestamp is preserved.
  3. Keep Firefox open, create a new Private window, and navigate to the same page.
  4. Download another random file from there. This time it fails - the file timestamp is not preserved.

@xiaoxiaoflood
Copy link
Owner

Thanks, I was able to reproduce, but in normal browsing mode, seems inconsistent, I don't know yet, will try too look at. Do you know if this is a regression from recent versions? Did it work for you in the past, like in 2022?

@jiangzhenjerry
Copy link
Author

@xiaoxiaoflood Now that you reminded me - Yes, it did break in 2023. Actually I reported it in #259 (comment) and @xelsios fixed it at that time.

Right now I am using the binary here #274 (comment) and it works fine, too.

@xiaoxiaoflood
Copy link
Owner

Thanks. Tested here with v111 and it was working. I will run mozregression later to try to find what caused the regression.

@xiaoxiaoflood
Copy link
Owner

Fixed version has been uploaded..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants