Support for XMPP rosters on connect #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Expose the XMPP client through the robot to allow third-party scripts | ||
| # to send messages directly | ||
| @robot.xmppClient = @client | ||
| @robot.xmppRoster = [] |
There was a problem hiding this comment.
I thought the robot had a reference to the adapter it was using. I could be wrong though.
There was a problem hiding this comment.
Apparently there is a robot.adapter. I will make sure it works the same as what I'm doing.
There was a problem hiding this comment.
You would need robot.adapter.client.
There was a problem hiding this comment.
Confirmed that robot.adapter.client works
|
Your most recent commits have failing tests. |
|
There were some issues with my original PR, and the script I'm using this with needed to get caught up to a newer version of hubot, so I'll have to do some more work on this tonight. |
|
If this had some tests, I would be happy to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to eliminate the need for a running a fork of hubot-xmpp just to enable (#41) roster support. The change is pretty minor. The goal here is still to allow for a script like PRX/party-line-hubot@b838526 to work as a relay/broadcast system over XMPP.
The extra conditional in
readIqI think it pretty straight forward. I have my doubts about how I exposed@robot.xmppRosterand@robot.xmppClient. The client may have already been accessible from the robot and I just wasn't sure how, and it may make more sense for the roster to be a property of the client, not the robot. Looking for feedback on either of those points.If there's a way to accomplish this by extending hubot-xmpp in another library, rather than making this change here directly, I can go that route as well. I just wasn't sure how to intercept the
readIqblock in a good way to do that.I will add some tests before this gets merged.