-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No API to remove an iq callee route #779
Comments
Some background here: we use that to only react to routes if certain React components are mounted. |
Related #643 XMPP being stateful, is is very unusual to dynamically remove handlers. Usually it's your handler that would decide whether to trigger actions/changes or not. It is specially true for I believe it is a bad practice and would really advise against it, however I'm not totally against allowing it. @wichert could you elaborate on the use case? |
@wichert ping? |
Sorry for the late response. Your argument makes a lot of sense. I've already refactored our code to always have the plugin running. |
We used to be able to unregister an iq callee route like so:
This is no longer possible with the new middleware setup.
The text was updated successfully, but these errors were encountered: