Skip to content

Commit

Permalink
remove the default New Group (#818)
Browse files Browse the repository at this point in the history
  • Loading branch information
nplasterer authored Jun 6, 2024
1 parent 1871734 commit 0fa4336
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions xmtp_mls/src/configuration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ pub const MUTABLE_METADATA_EXTENSION_ID: u16 = 0xff00;
pub const GROUP_MEMBERSHIP_EXTENSION_ID: u16 = 0xff01;
pub const GROUP_PERMISSIONS_EXTENSION_ID: u16 = 0xff02;

pub const DEFAULT_GROUP_NAME: &str = "New Group";
pub const DEFAULT_GROUP_DESCRIPTION: &str = "New Group Description";
pub const DEFAULT_GROUP_NAME: &str = "";
pub const DEFAULT_GROUP_DESCRIPTION: &str = "";
10 changes: 5 additions & 5 deletions xmtp_mls/src/groups/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ mod tests {

// Verify bola can see the group name
let bola_group_name = bola_group.group_name().unwrap();
assert_eq!(bola_group_name, "New Group");
assert_eq!(bola_group_name, "");

// Check if both clients can see the members correctly
let amal_members: Vec<GroupMember> = amal_group.members().unwrap();
Expand Down Expand Up @@ -1570,7 +1570,7 @@ mod tests {
.attributes
.get(&MetadataField::GroupName.to_string())
.unwrap()
.eq("New Group"));
.eq(""));

// Add bola to the group
amal_group
Expand All @@ -1587,7 +1587,7 @@ mod tests {
.attributes
.get(&MetadataField::GroupName.to_string())
.unwrap()
.eq("New Group"));
.eq(""));

// Update group name
amal_group
Expand Down Expand Up @@ -1645,7 +1645,7 @@ mod tests {
.attributes
.get(&MetadataField::GroupName.to_string())
.unwrap()
.eq("New Group"));
.eq(""));

// Add bola to the group
amal_group
Expand All @@ -1662,7 +1662,7 @@ mod tests {
.attributes
.get(&MetadataField::GroupName.to_string())
.unwrap()
.eq("New Group"));
.eq(""));

// Update group name
amal_group
Expand Down

0 comments on commit 0fa4336

Please sign in to comment.